Upgrade to repo-config v0.5.2 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tooling
llucax
force-pushed
the
repo-config-0.5
branch
from
9e47cdd to
cdfec95
Compare
llucax
added
type:tech-debt
llucax
force-pushed
the
repo-config-0.5
branch
from
cdfec95 to
487a302
Compare
llucax
force-pushed
the
repo-config-0.5
branch
from
487a302 to
561e696
Compare
| class: mermaid | ||
| format: "!!python/name:pymdownx.superfences.fence_code_format" | ||
| - pymdownx.tabbed | ||
| - pymdownx.tasklist |
Contributor
There was a problem hiding this comment.
it seems pymdownx.superfences was removed in the commit Add and sort mkdocs markdown extensions. Was this deliberately done?
Contributor
Author
There was a problem hiding this comment.
Yes, it was duplicated. I clarified it in the commit.
Contributor
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
There was a problem hiding this comment.
I have only a question to check for and the PR needs rebasing to the latest v0.x.x
Marenz
reviewed
Sep 7, 2023
| recursive-exclude .github * | ||
| recursive-exclude docs * | ||
| recursive-exclude tests * | ||
| recursive-exclude benchmarks * |
Contributor
There was a problem hiding this comment.
We no longer exclude the benchmarks?
Contributor
Author
There was a problem hiding this comment.
Yes, from the source distribution package.
I misunderstood, you are right, this shouldn't be removed. Good catch!
Marenz
previously approved these changes
Sep 7, 2023
We always want to use the template provided extensions, keeping our own list only makes it more likely to have errors when upgrading. Signed-off-by: Leandro Lucarella <[email protected]>
The new template use it to show some help about cookiecutter variables, so we include it to avoid prompts when upgrading. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
This is to have a common basic configuration that should work with most editors/IDEs. Signed-off-by: Leandro Lucarella <[email protected]>
Now repo-config ships support to easily enable the collection and linting of code examples in docstrings, so we use that instead. Also make sure that we label the `conftest.py` file properly and we exclude it from the source distribution. Signed-off-by: Leandro Lucarella <[email protected]>
This is not really used in this project, but it is included as part of the repo-config ci template, as it doesn't hurt either. Signed-off-by: Leandro Lucarella <[email protected]>
When a PR is changing files in the `proto` or `py` directories, this workflow will fail if the release notes weren't updated in the PR too, unless the label `cmd:skip-release-notes` is set in the PR, which signals that this PR doesn't need a release notes update. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
This also removes a duplicated entry for `pymdownx.superfences`. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
repo-config-0.5
branch
from
7f99a56 to
e1e8344
Compare
Contributor
Author
|
Rebased and fixed the wrong removal of the benchmarks exclusion. |
Contributor
Author
|
It would be good to merge this soon (before merging other dependabot stuff) as I got a few conflicts when rebasing. |
Marenz
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the changes are related to regenerating the files using the cookiecutter templates in repo-config v0.5.2.
Introductionvariable